Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 112
    • Merge requests 112
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1720

Klipper: Tidy up the "Actions" configuration page and editing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Marten requested to merge marten/plasma-workspace:klipper-actions-config-2 into master May 12, 2022
  • Overview 45
  • Commits 56
  • Pipelines 8
  • Changes 11

This is the remaining part of the Klipper configuration dialogue, the "Actions Configuration" page. Now that the options have been moved to the "Popup" page, this is a simple tree view with action buttons. The explanations and help links have been moved to the "Edit Action" page, because that is where they are most applicable.

actions-config-design-2

The "Action Properties" dialogue uses a QFormLayout, and includes explanation text for the "Automatic" check box and the regexp help link.

edit-action-design

Instead of editing in place, the "Edit" button opens a further dialogue to edit the current entry. This is more discoverable and should be easier on small displays than editing in place, although a double click is still accepted. This dialogue has explanation text for substitutions.

edit-command-design

The icon for a command can be set explicitly, for those cases where the automatic detection (from the first word of the command) does not work.

Confirmation is requested when deleting a command or an action.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: klipper-actions-config-2