Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 85
    • Merge requests 85
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1820

Klipper (classic widget): Fix a system tray menu memory leak

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Marten requested to merge marten/plasma-workspace:klipper-memory-leak into master Jun 08, 2022
  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 1

Clipboard history item actions are added to the menu by KlipperPopup::rebuild() or PopupProxy::tryInsertItem(). The actions are removed from the menu again at the start of KlipperPopup::rebuild(), but were never deleted.

Without this change, the RSS of the Klipper process increased from 71Mb after startup to 99Mb after about 5,000 clipboard changes and menu rebuilds (automated with a script using DBus and xclip). With this change, the RSS remained at 71Mb even after more than 10,000 menu rebuilds.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: klipper-memory-leak