Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 107
    • Merge requests 107
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !183
The source project of this merge request has been removed.

[applets/digitalclock] Custom Time Format Support

Closed Ghost User requested to merge (removed):custom-time-format-digital-clock into master Aug 02, 2020
  • Overview 15
  • Pipelines 0
  • Changes 4

This adds support for custom time formats to the digital clock and reworks how seconds and 24/12 hour time is setup.

  1. Backwards Compatability: Is it okay that we removed the showSeconds option and reset the user's time settings?

  2. Visual Design:

    image

    • Does it look fine?
    • Are the hh/mm/ss specifiers able to be understood by the general user?
    • For reference, Windows looks like: time-long
  3. Intervals: Previously the interval was set by the showSeconds config option: interval: plasmoid.configuration.showSeconds ? 1000 : 60000. Now, this is not possible. I see three options:

    • Always update every second (doesn't work with the possible of the millisecond specifier)
    • Allow configurable intervals (works for all but a bit unwieldy)
    • Detect whether a specifier is used and autoconfigure based on that. See: Qt's AP recogniser
    • This needs to be removed as a TODO from the code before merging.
  4. Time Format Documentation: Would it be beneficial to include the format specifiers in a popup rather than linking to Qt's documentation? Especially given that the documentation link doesn't work; it doesn't scroll to the right part of the page. (an issue with qt's docs atm it seems)

  5. Time Displayed: I just chose an arbitrary time in the afternoon. This keeps it consistent as otherwise switching between will have the value change.

I think I had another point to discuss but forgot about it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: custom-time-format-digital-clock