Skip to content

kcms/users: don't let "Choose File…" text overflow

When using a language that's wordier than English and this label becomes a two-line string, currently the layout breaks and the string overflows because the Label item that draws it has no maximum height and elision mode set.

This commit fixes that by setting them accordingly, and also using a standard icon size for the icon so that there's actually enough room for two lines of text.

BUG: 458614 FIXED-IN: 5.24.7

@teams/vdg


Ultimately we should be able to use a basic QQC2.Button for this with display: QQC2.AbstractButton.TextUnderIcon rather than creating a totally custom content item. But that's currently broken and needs to be fixed separately, and this layout would need to be ported away from the custom content item afterwards. So let's fix the custom layout and backport the fix.

Before After
Before__one_line After__one_line
Before__two-line_string After__two-line_string
Before__long_string After__long_string

Merge request reports

Loading