Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 107
    • Merge requests 107
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !2315

applets/batterymonitor: count as fully charge when at charge limit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-workspace:fully-charged-when-at-charge-limit into master Nov 09, 2022
  • Overview 2
  • Commits 1
  • Pipelines 4
  • Changes 2

When the user has set a charge limit, the expected definition of "fully charged" changes from "100%" to "the charge limit that I set". Accordingly, let's use the term "fully charged" to describe the current state when the battery is at the configured charge limit.

Unfortunately this involves a bit of code duplication in logic.js because the code in there to generate a charge status label is separate from the logic in main.qml that sets the label for the tooltip. At some point in the future, it would be nice to unify those.

Tooltip Label in popup
Tooltip in_popup

@teams/vdg @broulik

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fully-charged-when-at-charge-limit