Skip to content

kcms/nightcolor: Change mode names to be clearer and remove inconsistency

Oliver Beard requested to merge (removed):night-color-names into master

image

This MR renames:

  • "Always off" -> "Night color disabled"
  • "Always on night color" -> "Always on"

My reasoning is that "Always off" is more clearly understood as disabling Night Colour, rather than in some way being the opposite of always on where Night Colour might be able to be turned on manually by the applet, but is off by default.

"Always on night colour" is redundant, and can be simplified. If this was done without changing "Always off", it would also be odd that the choices are not adjacent. The order is fine - this isn't a common option unlike outright disabling Night Colour, so I think these changes work.

Edited by Oliver Beard

Merge request reports