Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 119
    • Merge requests 119
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !2735

Screenpool: avoid uniqueConnection with lambda

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/d_ed/screen_connect into master Mar 10, 2023
  • Overview 2
  • Commits 2
  • Pipelines 3
  • Changes 2

Handling QScreen geometryChanged was connected to a lambda with a unique connection. Qt cannot determine this and doesn't connect.

The unique connection was used as handleScreenAdded is also called when the output order changed to handle things being async. (I don't think that's actually needed, but that's a refactor for another thread)

This patch shuffles the code so we only connect once which is cleaner anyway.

CCBUG: 466312 CCBUG: 466020

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/d_ed/screen_connect