Skip to content

Draft: Don't show unnecessary auth dialog when LUKS password is found in wallet

Nate Graham requested to merge work/ngraham/luks-kwallet-password into Plasma/5.27

Currently when mounting a LUKS-encrypted volume, if a saved password is found in KWallet, the auth dialog still appears, but it has the password field pre-populated. This is a bit odd and doesn't match what typically happens when there's a saved password: it's simply sent along, without showing a dialog at all. This commit does that here too for a smoother workflow.

BUG: 467098 FIXED-IN: 6.0

Draft because this is buggy and I've reached my limit of understanding of DBus and need help. Bugs:

  1. When decryptVolume() is run after accepting the dialog, everything works. But when it's called before the dialog is created, after checking KWallet and finding a saved password, the DBus call it runs doesn't receive a reply. Log says:
kf.solid.backends.udisks2: Failed to call the SolidUiServer, D-Bus said: QDBusError("org.freedesktop.DBus.Error.NoReply", "Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken."
  1. Canceling the password dialog make it spin in the tray widget

(Also this is not actually intended for 5.27; I just developed against that for now since I don't have a Plasma 6 dev environment set up yet)

Edited by Nate Graham

Merge request reports