Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 119
    • Merge requests 119
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !298

System tray highlight animations are more consistent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged andy salerno requested to merge andy/plasma-workspace:work/ImproveSystemTrayAnimations into master Sep 28, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

I noticed some strange behavior in the animation of the system tray applet highlight.

For context, here's the system tray with the network applet active/highlighted: systray

Here's the weird behavior I was seeing, in both slow and default animation speeds:

old_tray_behavior.mkv

This is the problem: the indicator is bound to the active applet if there is one, otherwise it is bound to the tray, which makes sense. When an applet is closed, the indicator's parent changes from the applet to the entire tray. While the indicator is fading out, you can see it animate its x/y/width/height to match its new parent, the tray.

This MR change the behavior so in that case, we perform the opacity animation, but not the x/y/width/height animation.

new_tray_behavior.mkv

also, changed the Easing of existing animations from Quad to Cubic per the HIG

Edited Sep 28, 2020 by andy salerno
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ImproveSystemTrayAnimations