[applets/devicenotifier] Don't offer to unmount non-removable devices
requested to merge ngraham/plasma-workspace:fix-device-default-actions-for-non-removable-devices into master
The previous check for whether a device was non-removable in the delegate was faulty and was doing too much work, which caused it to miss non-root internal disks. In fact, we can already get this data straight from the data engine. This fixes the bug and removes code in net.
All types of devices now have the correct default action:
simplescreenrecorder-2020-10-13_09.45.18
BUG: 427176 FIXED-IN: 5.20.1
Edited by Nate Graham