Skip to content

Address regressions from lockscreen fingerprint auth

David Edmundson requested to merge work/d_ed/lockscreen_fixes into master

The commit introduced the idea of tying the UI to the authentication state. Starting and cancelling as the UI became visible. Whilst nice on paper this had two critical bugs:

  • cancelling an interactive authentication leads to an entry in the faillock list. This means pressing escape 3 times in quick successsion could lock you out your account for 10 minutes.

  • There was a concept of a failed state, which wasn't handled in the UI properly leading to prompts disappearing.

The notification about the failed lock could not be seen.

It also failed to handle the prompts correctly, we had multiple things bound to the same root.notification completely ignoring the handleMessage function which is trying to stack messages.

This reverts some of commit 59cdc995, but keeps the core feature.

BUG: 477326 BUG: 465266 BUG: 476293

Edited by David Edmundson

Merge request reports