Skip to content

kcms/nightlight: overhaul switching mode UI

before after
switching modes before_switchingmodes after_switchingmodes
(auto) location mode before_autolocation after_autolocation
no location given after_warningmessage

move enabled control to header action

It being a pseudo mode in the "Switching times" control was confusing UX, even more so now that the switching times control has moved below the temperature sliders. Make it a checkbox in the header instead.


show preview when turning on enabled switch

So the user gets an idea at a glance what the feature is about.


merge automatic and manual location into single switching times mode

This simplifies the UI, and makes it possible to require the user to explicitly consent to being autolocated, which is needed now that the enabled control has been moved into a separate control, and given the default switching mode is autolocation, since otherwise turning the night light checkbox on would immediately start the locator.


add control for switching between automatic and manual location

This implements the UI for switching between automatic and manual location with the new unified location switching times mode by using a checkbox for whether the location should be determined automatically.


use combined map view for auto and manual location modes

This is a natural consequence of the combined auto and manual location UI, and provides a nicer presentation of the automatically determined location by showing it on a map instead of only a text label.


prevent saving with location mode and no valid location data given

When night light has been set to enabled and the switching mode to location, but neither consent for autolocation nor manual coordinates were given, disable the Apply button to prevent saving with an invalid configuration, and show an inline warning message.


@teams/vdg @ratijas @bharadwaj-raju

Edited by Natalie Clarius

Merge request reports