Skip to content

kcms/users: Small code improvements

ivan tkachenko requested to merge work/r/users-one into master
  • Don't qualify properties and methods with this keyword

It is unnecessary in QML/JS, we usually don't do that.

  • Simplify superfluous method on Action object

  • Port to better data structures and algorithms

A static std::array is more efficient than an std::list; a destructuring syntax in the loop is more ergonomic than querying .first/.second of a pair; and std::ranges provides a shorter and more convenient syntax than the .begin()/.end() idiom.

  • Remove superfluous default constructors

QString and QUrl members can default-initialize themselves properly.

Merge request reports