Skip to content

dataengines/weather/envcan: Use https for queries

Ismael Asensio requested to merge work/iasensio/envcan-https into master

Reason for the change

Save unnecessary redirections from http: to https:, which sometimes might even fail

Test plan

No visual or behavior changes, but on the console output

  • Enable debug output for the ion: export QT_LOGGING_RULES="kde.dataengine.ion.envcan=true"
  • Use plasmoidviewer -a org.kde.plasma.weather to watch the debug output
  • Select an station from Canada using the envcan provider

BEFORE (kio redirections):

kf.kio.core: mimetype() emitted again, or after sending first data!; job URL = QUrl("https://dd.weather.gc.ca/citypage_weather/xml/siteList.xml")
kf.kio.core: mimetype() emitted again, or after sending first data!; job URL = QUrl("https://dd.weather.gc.ca/citypage_weather/xml/ON/s0000623_e.xml")

AFTER:

kde.dataengine.ion.envcan: Fetching station list: QUrl("https://dd.weather.gc.ca/citypage_weather/xml/siteList.xml")
kde.dataengine.ion.envcan: Fetching weather URL: QUrl("https://dd.weather.gc.ca/citypage_weather/xml/ON/s0000623_e.xml")

Screenshots or screen recordings

No visual changes

Bugs fixed

BUG: 477377
FIXED-IN: 6.2

Other commits

  • dataengines/weather/envcan: Improve debug output
Edited by Ismael Asensio

Merge request reports