kcms/notifications: drop "…" from location buttons
Original commit message(s)
- kcms/notifications: drop "…" from location buttons
The HIG recommend the use of ellipses on buttons that represent actions and require further user input, like "Configure x…" or "Add…". Buttons that represent locations should instead have their label match the location that they link to, if possible. kcm_notifications has two header buttons that each represent a location, namely "System Notifications" and "Application Settings", but both end in ellipses as if they were actions.
This change removes the ellipses from these buttons.
Reason for the change
See the HIG section on Text and labels:
An action makes something happen, and begins with a verb in the imperative mood appropriate to describe the action. If the action is complex and requires additional user input before it completes (most commonly because it opens a dialog that prompts the user to make a further decision), end its label with an ellipsis. […] A location is another page, window, or sub-menu that opens when the user triggers the button or menu item. Match the title of the new page or window in the button or menu item label.
Test plan
Changes were built using KDE builder, and verified by restarting System Settings.
Screenshots or screen recordings
Before | After |
---|---|
Additional note: The "System Notifications" button currently does not follow the guidelines on naming for location buttons, as the target page is named "Plasma Workspace". The label here is better, and the target should be updated. A MR regarding this is in the works, but I'm having trouble getting my kde-builder installed session to read the updated notifyrc file instead of the system-installed one, so I haven't been able to verify it works and create screen shots.