Skip to content

kcms/autostart: remove ellipses from menu button

Original commit message(s)

  • kcms/autostart: remove ellipses from menu button

kcm_autostart uses a Kirigami.Action in its header that turns into a menu button due to its child actions. The Action has the label "Add…". While the HIG recommend the use of ellipses for buttons with Action labels that require further user input, this was recently updated to exclude menu buttons as this is redundant with the downward-pointing arrow on this control.

This change removes the ellipsis, and adapts the appium test to this.

  • kcms/autostart: adjust button and menu labels

This kcm has a menu button in the header labeled "Add", with menu items like "Add Application…" that specify what kind of entity should be added to the list. The labels here do not match the current practice across kcms, which tend to label the button "Add New", and also to remove the redundant verb (in concordance with the general recommendation in the HIG to keep menu and button labels short).

This change adds "New" to the button label, removes the extra verb, and adapts the translation context, placeholder message, and appium test to match these changes.

  • kcms/autostart: prepare for setting action a11y

The button menu in the header of this kcm uses context to shorten the labels, which makes them harder to with screen readers. Currently Kirigami.Actions cannot have an Accessible.name set directly, but Qt 6.8 will support this.

This change adds comments that set the Accessible.name, along with instructions to uncomment them once Qt 6.8 is required.

Reason for the change

The HIG were recently updated to make the labeling of menu buttons more consistent, see documentation/develop-kde-org!449 (merged)

For the changed labels, one of the main goals was consistency with kcm_keys, see the screen shot for reference. Matching the "Command or Script" text in kcm_autostart does not make sense at the moment, as the item does not allow entering a command directly like in kcm_keys, but opens a file picker instead.

kcm_keys_reference

The HIG recommend setting Accessible.name on buttons with shortened labels that rely on context, see Text and labels.

Test plan

Compile new version, confirm absence of ellipses and the new text visually.

Screenshots or screen recordings

Before After
kcm_autostart_old kcm_autostart_new
Edited by Christoph Wolk

Merge request reports