Skip to content

dataengines/weather/noaa: Improve handling of server errors

Ismael Asensio requested to merge work/iasensio/fix-noaa-disconnects into master

This makes the ion more robust against wrong updates because, on any server error on the chain, we will keep the previous data instead of cleaning everything up and display an awful timeout message.

Also improve the logging of these errors.

Unintentionally introduced in c8cd82cc because the reset mechanism didn't actually work before

Test plan

As the server errors happen sporadically I can only recommend to leave the applet with this modification running on the background for a while. It shouldn't take much and ideally no timeout errors occur anymore.

I'm keeping it now with two fast updating instances (with/without) but it's hard to compare because the API requests are not the same in those instances

Bugs fixed

The weather applet timing out frequently on the NOAA provider

Merge request reports