Skip to content

libtaskmanager: Fix transient losing needs attention state

Kai Uwe Broulik requested to merge work/kbroulik/libtm-transient-undemand into master
  • libtaskmanager: Fix transient losing needs attention state

transientsDemandingAttention uses leader/parent as key and transients as values, so use the correct remove(key, value) method.

Migrating from one parent to another was using the right one but not here.

Reason for the change

As part of xdg-desktop-portal-kde!333 (merged) I noticed it was glowing in taskbar indefinitely. Then I realized it affects pretty much all dialogs where direct xdg activation failed (e.g. usually opened from a context menu). While this is also some kind of bug, the window typically enters needs attention state only briefly when it then gets focused anyway.

Didn’t test the X11 side but the code is pretty much copy pasted from there, so I assume it was broken in the same way.

@hein @davidedmundson @fusionfuture

Test plan

  • Right clicked in Dolphin, clicked New → Folder. Folder dialog opened, Dolphin no longer stayed glowing orange until restarted.

Bugs fixed

Surprisingly didn’t find one

Merge request reports