Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 111
    • Merge requests 111
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !553

[panel] Fix crash on screen changes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/crash into master Jan 05, 2021
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

There is an error handling path when we fetch the relevant config()

KConfigGroup PanelView::panelConfig(...
{
    if (!containment || !screen) {
        return KConfigGroup();
    }

which we indiscrimiately call parent() on.

This patch guards that case, which is presumably screen being temporarily null.

This code is also Plasma 5.8 compatibility fallback, so arguably we could get rid of it.

BUG: 425711

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/crash