Skip to content

Fix actions for application search results

Alexander Lohnau requested to merge work/alex/fix_application_editing into Plasma/5.19

If you search for an application and click edit the dialog would not open. This is because the data from the SeervicesRunner is an QUrl and when we convert it to a string we still have the scheme. This causes the service to become null.

ServicesRunner impl:

QUrl url(service->storageId());
url.setScheme(QStringLiteral("applications"));

...

match.setData(url);

We should also be able to launch applications/services normally.

This has also been reported by users: https://www.reddit.com/r/kde/comments/h12w05/updated_to_519_found_some_issues/ and

BUG: 422712

And another few actions should work again (addToDesktop addToPanel addToPanel) because they depend on the service not being null.

This seems to be a regression from https://phabricator.kde.org/D28347.

@davidedmundson @broulik

Edited by Alexander Lohnau

Merge request reports