Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 107
    • Merge requests 107
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !62

Fix race in loading DBus activatable applets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/systray_start into Plasma/5.19 Jun 11, 2020
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 2

If a service was registered between us requesting a list of names from the daemon and us processing the reply we would miss it. An event somewhat likely given plasmashell is very busy during startup.

DBus does guarantee preserved message order, so the correct thing to do is:

  • create a match rule for new servies on DBus daemon
  • start fetching a list of names
  • ignore all changes that happen in the meantime
  • handle the list of all names

BUG: 422111

Edited Jun 11, 2020 by David Edmundson
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/systray_start