Skip to content

Revert "Use subseq matching for service runner"

Harald Sitter requested to merge work/nosubseqmatch into master

This reverts commit 9f2abd0a.

Scores are adjusted by launch count, so pulling more matches into a context increases the chance of one of them outscoring the other even though they have nothing to do with it.

Notable example: Flatpaks have extremely long Exec lines meaning they match just about any subsequence match once we've reached 3 query characters. So then a konversation flatpak matches the query 'tel' same as telegram. Now if you are more into IRC than into telegram you may have a higher launch count applying to konversation and all of a sudden the objectively better match for the query is no longer at the top.

In lieu of a way to prevent this from happening with krunner 5.78 we'll need to undo the subsequencing for now.

For future reference: Kai and I believe Exec and Comment shouldn't be subsequence matched at all because Exec just makes no sense to begin with and Comment can be so very long so it will suffer the same problem as outlined. The more text there is the higher the chance of it matching the subsequence simply having having all the characters appear anywhere.

Further future reference: subseq needs a test case added to the unit test if it makes a return!

BUG: 431609 BUG: 432339 CCBUG: 262837 FIXED-IN: 5.21.0

Merge request reports