Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 111
    • Merge requests 111
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !74

[wallpapers/image] Remove outdated calls to setAction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daan De Meyer requested to merge daandemeyer/plasma-workspace:fix-set-action into master Jun 14, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Currently, my log contains the warning:

file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/main.qml:63: TypeError: Property 'setAction' of object ScreenLocker::WallpaperIntegration(0x5602870c3910) is not a function

And indeed, the WallpaperIntegration class in KScreenLocker does not contain such a function. Removing the calls to setAction fixes the warning but I'm not entirely sure if this is actually a regression that should be fixed by replacing the calls to setAction by something else. Any guidance here would be appreciated.

I tried to do more investigation but I end up at the start of the history of the plasma-workspace and kscreenlocker repositories so I don't know if there's any more git blame delving I can do here.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-set-action