Skip to content

[Media Player] Skip source if it doesn't exist

Kai Uwe Broulik requested to merge work/kbroulik/mediaplayer-skip-nosource into master

We get sourceRemoved emitted before the source is actually removed from the list.

This is a regression from 5984d4960fa5ecf60a20b1fbc782fb841faa4af7 in plasma-framework but better be safe than sorry.

BUG: 439309 FIXED-IN: 5.23.3

@davidedmundson @kmaterka

I think we need to fix that commit too to be:

d->sources.erase(it);
Q_EMIT sourceRemoved(source);
s->disconnect();
s->deleteLater();

I would not expect something to still be listed if I got a removal signalled...

I wonder if that is also what made media controls in Task Manager unreliable, though it doesn't use sourceRemoved explicitly and already checks for .data[source] being not undefined

Edited by Kai Uwe Broulik

Merge request reports