Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • PowerDevil PowerDevil
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • PowerDevilPowerDevil
  • Merge requests
  • !127

Do not hardcode ACPI battery names

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Hector Martin requested to merge marcan/powerdevil:non-acpi-battery-fix into master Dec 25, 2022
  • Overview 9
  • Commits 1
  • Pipelines 4
  • Changes 1

The BAT* naming convention is strictly an ACPI thing, so the charge control helper fails to work on non-ACPI platforms (like many embedded ARM devices including Apple Silicon Macs).

The correct way to enumerate batteries is to use the type property.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: non-acpi-battery-fix