Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • PowerDevil PowerDevil
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • PowerDevilPowerDevil
  • Merge requests
  • !26

Honor animation brightness threshold also for sysfs helper

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kai Uwe Broulik requested to merge work/animthreshold into master Oct 08, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

We should only animate the screen brightness if there are enough steps available to make for a smooth transition. This check was forgotten for the new sysfs brightness animation.

BUG: 426883 FIXED-IN: 5.20.0


Animation unchanged on my machine, changed

To simulate added the following into ~/.config/powerdevilrc:

[Brightness]
brightnessAnimationThreshold=5000

Brightness wasnt animated anymore

The default threshold is 100, so should fix the bug reporter's machine where there are only 15 setps.

I'd like a respin for 5.20 powerdevil, please, sorry.

@ngraham @davidedmundson @jriddell

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/animthreshold