Cycle through power profiles on Meta+B with non-interactive OSD
The interactive OSD implementation from MR !186 (merged) was a lot of work, but little discussion happened at the time about whether it should be interactive at all.
Arguments have since been made that the low number of selectable power profiles, and the non-destructive character of switching between them, would make power profiles a better fit for immediately switching profiles on shortcut presses with a non-interactive OSD.
This commit implements simple power profile cycling on Meta+B in
the PowerProfile
action, and uses the Plasma OSD service's
pre-existing "powerProfileChanged"
method to display a
non-interactive OSD popup once the profile was applied.
In turn, the entire interactive OSD service can be deleted
from PowerDevil, reducing complexity. The corresponding global
shortcut definition moves from PowerDevilApp
to the PowerProfile
action, similar to global shortcuts from other PowerDevil actions.
(This makes PowerDevil shortcuts actually show up in the Shortcuts
KCM as "Power Management" rather than the default app title from
KAboutData
called "KDE Power Management System".)
CC various stakeholders:
- @nclarius, who was in fact the driving force between both the interactive OSD (MR !186 (merged)) and the non-interactive OSD (plasma-workspace!3557 (merged)).
- @root-core who contributed MRs !367 (merged), !368 and !369
- @justinzobel and @genericity of BUG: 469487 and BUG: 476921 respectively.
- @ngraham and @ratijas who participated in the relevant UX discussion within !368.