Consistent indent between QWidgets/QML Titles
Currently we have an issue with different title padding between QML and QtWidget KCMs in System Settings.
Values for default breeze settings | CURRENT |
---|---|
QML (Kirigami.gridUnit : 18px) |
|
QWidgets (Style.leftPadding : 6px) |
This makes an inconsistent look between the two, and uncomfortable feeling of titles "jumping" between the different KCMs (https://bugs.kde.org/show_bug.cgi?id=460103.)
The implementation is not trivial, as the two toolkits use a totally different architecture, and the small fixes to do it properly expand across serveral repos. It will depend on where do we want to achieve this. To make it more robust, I think we better establish the desired value in a single point, and then set it to the KCMs of the different toolkits.
I've split the different tasks to make it easier to follow-up the progress, and to help making my mind (and others') around the issue
DECISIONS (@teams/vdg)
-
Where do we establish the value? : Only in SystemSettings? | Globally for all KCMs? (in kcm-utils) I lean towards doing it just in SystemSettings, because it is where the issue is more perceptible, and we can have a finer control of the effects. It also depends already on
Kirigami
so we can use their units easily. -
Which value? ( Kirigami.gridUnit
|Kirigami.largeSpacing
| other )After the latest attempts, I like using largeSpacing because it shows a better alignment with the page content for both toolkits (in general, there can be exceptions). But this is open to discussion, there will be no one-size-fits-all (literally).
ENABLING TASKS
-
Expose the title left padding for QML pages to the globalToolBar
application object (frameworks/kirigami!778 (merged)) -
Expose the title left padding property to the modules (or an accesor to globalToolBar
) (kcm-utils/kcmoduleqml)
APPLYING TASKS
-
Set the value for QML KCMs -
Set the value for QWidgets KCMs (sidebar view). It has a custom component (!144 (merged)) -
Set the value for QWidgets KCMs (icons view).