Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • System Settings System Settings
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • System SettingsSystem Settings
  • Merge requests
  • !106

Merged
Created Dec 15, 2021 by Nate Graham@ngrahamDeveloper

Don't show unnecessary root authentication message

  • Overview 4
  • Commits 1
  • Pipelines 8
  • Changes 1

This message is pointless because the user will find out that they need to authenticate when they click the "Apply" button anyway. Showing the user this information ahead of time just contributes to visual clutter when it is even shown.

However the message hasn't even been shown for at least 9 months due to an intentional change in header height calculation to make the KCM header height always match the height of the category/subcategory sidebar header height. This had the side effect of entirely or mostly cutting off the authentication message. With the current design, there is no way to fix this without regressing the header alignment fix, and the message is pretty much unnecessary anyway, so the simplest solution is to not show it at all.

BUG: 434113 FIXED-IN: 5.24

Before After
Before After

observe the second line of text that you can select by triple-clicking in the "Before" view. Details of how it looks when unselected:

random-looking_dots

cc @teams/vdg

Edited Dec 15, 2021 by Nate Graham
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/ngraham/dont-show-root-authentication-message