Skip to content

Sidebar: Keep headers minimum height on two columns

Ismael Asensio requested to merge work/iasensio/header-height-again into master

The implicitHeader binding from sizeHelper is getting overriden by Kirigami.AbstractApplicationHeader, which recalculates a preferred height using the header's childrens implicit heights.

What's really keeping the header height at the desired value is the hamburger button, so let's keep that size also when showing two columns

BUG: 448889 FIXED-IN: 5.24

Note I don't specially like this solution 😄 but after several try-outs this was the simplest one that would work.

Merge request reports

Loading