Skip to content

ModuleView: Simplify and fix custom headers logic

Ismael Asensio requested to merge work/iasensio/fix-sheet-issue into master

Apart from a minimum logic refactor, this introduces two fixes:

  • Only affect custom header visiblity for current page
  • Do not set customHeader text when not visible

When calling KTitleWidget::setText(), this would set the custom header visible again. So do it only if we want it actually visible.

This fixes the issue in kscreen#4 (closed), so the workarounds to show the OverlaySheet can be removed.

CC: @dominichayes @ngraham @xuetianweng

Edited by Ismael Asensio

Merge request reports