Skip to content

Fix up connect() call, and add null check for consistency

ivan tkachenko requested to merge work/ratijas/fixup-connects into master

Elsewhere below in this file there are null checks before using activeView, so let's not give compilers a reason to think that there is a possibility of an undefined behavior here without a check.

Amends 87c21c25

other changes

  1. Use modern syntax for connect() calls

  2. Add null check before adding actions

Avoids warning QWidget::insertAction: Attempt to insert null action, since at least the "configure" action is not always present (in fact, it's practically not used in any of the available modes anymore).

Merge request reports