Skip to content

Sidebar: Move final trailing separator out of main layout

ivan tkachenko requested to merge work/ratijas/sidebar-scrollbar-centered into master

tl;dr The scroll bars must not be overlayed with foreign items like frame borders, separators etc. They are doing fine on their own. Don't.

And since Kirigami.ApplicationItem was not designed for this kind of usage where you stick something permanent to one side, just more it out completely in its own layout. Components are refactored in different files, so that semantics of ApplicationItem being a QML context on its own is preserved, and properties, methods & signals are wired together to act as a proxy.

With Breeze and Kirigami patches applied, this MR make the following 1px difference:

State Before After
"usual"
category
Before_-LTR-_1 After_-LTR-_1
"usual"
sub-category
Before_-LTR-_2 After_-LTR-_2
RTL
category
Before_-RTL-_1 After_-RTL-_1
RTL
sub-category
Before_-RTL-_2 After_-RTL-_2

Merge request reports

Loading