Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • System Settings System Settings
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • System SettingsSystem Settings
  • Merge requests
  • !193

sidebar: Use a proper checked state for the menu button

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arjen Hiemstra requested to merge work/ahiemstra/menubutton into master Feb 02, 2023
  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 1

We don't generally override down for setting the pressed state of menu buttons, instead we use the checked state, which is subtly different visually.

Moreover, using onPressed here causes a weird behaviour where any subsequent press after clicking the "highlight changed settings" menu item will re-open the menu on wayland, probably caused by the same source as https://bugs.kde.org/show_bug.cgi?id=464855 . Using onToggled instead will prevent this.

BUG: 464536

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahiemstra/menubutton