Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KDE Portal for XDG Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KDE Portal for XDG Desktop
  • Merge requests
  • !122

don't construct invalid paths

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Harald Sitter requested to merge work/fixcurrentname into master Jul 18, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

tear this logic apart a bit to make it easier to comprehend. previously it was trying to be too smart for its own good.

the previous code would url.todisplaystring (this returns a url if the input was an url - e.g. file:///foo) but then used that with fromLocalFile (which prepends file:/) ultimately ending up with file:file://foo.

instead let's manipulate the path proper-like. append to the path(), then simply pass along the url, no localfile conversion necessary at all

BUG: 428373

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/fixcurrentname