Skip to content

AppChooserDialog: improve text presentation

Nate Graham requested to merge ngraham/xdg-desktop-portal-kde:improve-appchooser-dialog into master

Depends on plasma-workspace!2255 (merged).

Four commits which should not be squashed:

commit e5d90bb551a613a061dc52f5591655e61f8db9aa
Author: Nate Graham <nate@kde.org>
Date:   Sun Oct 23 08:08:40 2022 -0600

    AppChooserDialog: Select -> Choose
    
    The word "Choose" is a bit less formal-sounding in English, and also has
    fewer syllables.
commit 407db5d21730c10809fe3a015ec8bf41b0fb1239
Author: Nate Graham <nate@kde.org>
Date:   Sun Oct 23 08:07:17 2022 -0600

    AppChooserDialog: Use KUIT markup to style filename
    
    This is the semantically correct way to represent filenames.
commit 0003a63d2f7337fcdc24cc532f20c74cd4ee10a6
Author: Nate Graham <nate@kde.org>
Date:   Sun Oct 23 07:57:18 2022 -0600

    AppChooserDialog: set title and mainText separately
    
    Right now this code is making use of a bug in SystemDialog.qml which
    causes the title property to be duplicated across both the window title
    and also the main text in the dialog itself. This is now fixed in
    SystemDialog, so now let's use the API properly and set the title and
    mainText properties separately to improve the presentation of the
    dialog.
commit 2a0ff3c5bc6393e1df3363f878f60fb611b2005d
Author: Nate Graham <nate@kde.org>
Date:   Sun Oct 23 07:55:39 2022 -0600

    AppChooserDialog: show only filename, not whole path
    
    The entire path is overkill to show, because the user either already
    knows where the file lives, or doesn't care. Hiding everything but the
    filename also fixes the problem of showing the ugly URL scheme (e.g.
    `file://`) in a user-facing string.

If approved, I would like to backport AppChooserDialog: show only filename, not whole path to the stable branch.

Before After
image image

@teams/vdg @teams/usability @apol

Merge request reports