Skip to content

Fix check for malformed input when decoding translations

Andreas Sturmlechner requested to merge asturmlechner/qtbase:coverity-11014 into kde/5.15

Any integer modulo 1 can never be anything else but 0, so the statement could never be true. The intention is to abort in case of an odd number of bytes, as this would indicate malformed input that can't be decoded into a QString.

Note that QTranslator will then silently continue to search for valid translations, and not print any error message at runtime, or otherwise inform the user or developer that an input message file contains malformed content.

Change-Id: I957b337ee035f3aca013e0859f8ee70553d9a97b Coverity-Id: 11014 Reviewed-by: Oswald Buddenhagen oswald.buddenhagen@gmx.de (cherry picked from commit 458d4986)

Merge request reports