Skip to content

QAbstractItemDelegate: fix rect given to tooltip handing

Andreas Sturmlechner requested to merge asturmlechner/qtbase:tooltip-handling into kde/5.15

  • The rect passed to QToolTip::showText() is in view coordinates, not in global coordinates.

  • Determining this rect in the first place doesn't need calling view->visualRect(index) The view already did this before calling this method, and stored it in option.rect, so just use that.

  • The widget passed to QToolTip::showText() should be the viewport, that's what option.rect is relative to (thanks Giuseppe!).

Found these issues when implementing my own tooltip handing (for a subrect of a delegate) by looking at this code.

Pick-to: 6.3 6.2 5.15 Change-Id: I852e5409def28da98137cd0c4c996083e5e45706 Reviewed-by: Richard Moe Gustavsen richard.gustavsen@qt.io (cherry picked from commit 741afd67)

@dfaure

Merge request reports