Skip to content

xcb: correctly disconnect xsettings callbacks

David Edmundson requested to merge (removed):work/d_ed/cursor_crash into kde/5.15

registerCallbackForProperty can be initialized without us completely initialializing a GTK theme. We need a different guard for the destructor.

(part cherry-picked from 012132c6)

This is potentially slightly controversial and needs some input.

  • This was fixed upstream, but as part of a big refactor (above)
  • The refactor is too big to backport, but more importantly has new deps.

The patch is effectively written from scratch copying the relevant few lines from the commit. It's within the spirit of the rules of making sure we don't need to carry patches after the Qt6 switch.

Relevant downstream report: https://errors-eval.kde.org/organizations/kde/issues/500/?project=8

Edited by David Edmundson

Merge request reports