Skip to content

QHostInfo: fix remaining slotObj leaks

Andreas Sturmlechner requested to merge asturmlechner/qtbase:asturmlechner/QTBUG-115263-QHostInfo-leaking-slot-obj into kde/5.15

We failed to delete the slot object when lookUpHost() was called in these (exceptional) circumstances:

  • on a thread with no event dispatcher

  • after application shut-down, when the QHostInfoLookupManager Q_APPLICATION_STATIC was destroyed already

Fix by adding the missing destroyIfLastRef() calls into these code paths, too.

Amends ad5eb297.

This would be so much easier if we had SlotObjUniquePtr...

Pick-to: 6.6 6.5 6.2 5.15 Task-number: QTBUG-115263 Change-Id: Ief8bf125bc196742c0ce59c1fd87ab93242fc0da Reviewed-by: Ivan Solovev ivan.solovev@qt.io Reviewed-by: Qt CI Bot qt_ci_bot@qt-project.org (cherry picked from commit 693c9e6b)

Merge request reports