Skip to content

a11y atspi: Fix incorrect use of x instead of y position

Fushan Wen requested to merge fusionfuture/qtbase:work/fuf/cpa11yfixes into kde/5.15
a11y atspi: Fix incorrect use of x instead of y position

Fixes: QTBUG-105031
Pick-to: 6.4 6.3 6.2
Change-Id: I26fcbfbd5a90982b87dda89b2880efe937f099d8
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit d40dacf5f4697a57314ec77709e4551977d97c29)
a11y atspi: Take dialog into account as top-level window

Since a dialog is also a top-level window, it should be taken
into account when trying to find the accessible's top-level
window, relative to which the position will be calulated for
`ATSPI_COORD_TYPE_WINDOW`.

Fixes: QTBUG-105042
Pick-to: 6.4 6.3 6.2
Change-Id: I74fae096fd886bab04187c122f268c26c91b86ab
Reviewed-by: default avatarTor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit 49c966bc)
a11y atspi: translate coords for GetOffsetAtPoint the right way 

The coordinate type for "GetOffsetAtPoint" describes the
coordinate type of the input coordinates and
`QAccessibleTextInterface::offsetAtPoint` expects the
coordinates in screen coordinates.

Therefore, if window-relative coordinates are given,
the screen coordinates of the window need to be added
(not subtracted) to the window-relative coordinates of the point
in order to calculate the screen coordinates of the point.

Fixes: QTBUG-105281
Pick-to: 6.4 6.3 6.2
Change-Id: I5517335c0c0d6a47b8c45c7e4f8f8b5a91f0fcd7
Reviewed-by: default avatarTor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit fa0e24b6)

Build log: https://build.opensuse.org/package/live_build_log/home:fusionfuture:branches:KDE:Qt:5.15/libqt5-qtbase/TW/x86_64

Edited by Fushan Wen

Merge request reports