Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Q qtdeclarative
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Qt Project
  • qt
  • qtdeclarative
  • Merge requests
  • !14
The source project of this merge request has been removed.

Fix TapHandler so that it actually registers a tap

Merged Arjen Hiemstra requested to merge (removed):work/ahiemstra/touchpoint into kde/5.15 Nov 15, 2021
  • Overview 4
  • Changes 2

This bug caused all quick examples that used the shared\LauncherList.qml to be broken.

In QtGui, QSinglePointEvent will construct itself with a point id of 0 if there is a valid point, and with a point id of -1 if the point is invalid (the default constructor does the latter). However, QQuickSinglePointHandler::wantsPointerEvent() did not agree with that, because it assumed that a point id of 0 meant uninitialized/invalid point. The fix is to change QQuickSinglePointHandler::wantsPointerEvent() and QQuickHandlerPoint so that it assumes that the id -1 is now an invalid point, (instead of 0)

Change-Id: I8c9683dfe06ebb77c5342a26f08174b67e7cbd90 Reviewed-by: Shawn Rutledge shawn.rutledge@qt.io (cherry picked from commit 8d3a9101)


I'd like to backport this because KWin internally can have touch points with id 0 which means things break if those are passed to Qt.

Edited Nov 15, 2021 by Arjen Hiemstra
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahiemstra/touchpoint