Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Q qtdeclarative
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Qt Project
  • qt
  • qtdeclarative
  • Merge requests
  • !39

Fix positioning of text decoration with some fonts

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Andreas Sturmlechner requested to merge asturmlechner/qtdeclarative:QTBUG-96700-QTBUG-97594-fix-text-deco into kde/5.15 Jan 18, 2023
  • Overview 3
  • Commits 25
  • Changes 34

Actually it just reverts 4db31cbd. When calculating a position for a decoration, we should just apply the decoration's offset to the line's baseline (line.y + line.ascent). The regression was introduced by 54b5287adf4f5b004fcf47840c7f2e1e561a90c1 in Qt 5.6, when we switched from prepending leading to the baseline of text and started appending it instead.

Pick-to: 5.15 6.2 6.4 6.5 Fixes: QTBUG-96700 Fixes: QTBUG-97594 Change-Id: I7f816b71859ffcb6b1c641f0c8b8e1d810bfc525 Reviewed-by: Eskil Abrahamsen Blomfeldt eskil.abrahamsen-blomfeldt@qt.io (cherry picked from commit 5d082dc9)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: QTBUG-96700-QTBUG-97594-fix-text-deco