Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • kdesrc-build kdesrc-build
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SDKSDK
  • kdesrc-buildkdesrc-build
  • Merge requests
  • !236

Add QT_PLUGIN_PATH to the build environment

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Jakob Petsovits requested to merge jpetso/kdesrc-build:work/jpetso/qt-plugin-path into master May 21, 2023
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

KDE's Extra CMake Modules currently use the value of QT_PLUGIN_PATH at configuration time to set it for later test execution. When ctest is run, the value of QT_PLUGIN_PATH at runtime does not actually matter because it was already fixed at CMake configuration time.

What ECM is doing is appending the application's own CMAKE_LIBRARY_OUTPUT_DIRECTORY to the existing QT_PLUGIN_PATH, such that both global and application-specific plugins can be found. However, by doing so it will miss the plugins directory inside of ${kdedir} because that wasn't set at configuration time. Not even activating prefix.sh will make plugin-reliant tests work.

This test failure can be avoided if QT_PLUGIN_PATH at configuration time includes the plugins path inside ${kdedir}. There's already a convenient location inside Module.pm that sets similar paths, an extra line there won't hurt and makes test execution easier.

Edited May 21, 2023 by Jakob Petsovits
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/jpetso/qt-plugin-path