Skip to content

Merge appxsigner into windowsbinariessigner

Ingo Klöcker requested to merge work/kloecker/unify-windows-signers into master

Both services share quite some code and do essentially the same: sign Windows artifacts. And Craft now uses the windowsbinariessigner for signing Windows binaries and the APPX sideload packages.

Changes in windowsbinariessigner:

  • Add special handling for single files. They are not packaged as zip before the upload.
  • Add verification of the application ID of APPX sideload packages.

I have tested the changes with NeoChat 23.08: https://invent.kde.org/network/neochat/-/jobs/1552007

Edited by Ingo Klöcker

Merge request reports