Skip to content
  • Stefan Brüns's avatar
    Make buttons in seach bar nicer (icon, tooltip, autoselect) · 9ce757b3
    Stefan Brüns authored
    Summary:
    The "Everywhere" button actually selects the home directory, so use
    an appropriate label ("Your files") and add a "user-home" icon.
    
    Pre-select the right button when entering search, depending on the
    location where the "Find ..." action was triggered.
    
    Add tooltips for both buttons, stating where to look for files. Most
    importantly, this includes the full path for "From here".
    
    Canonicalize the path correctly (always strip trailing slash), otherwise
    QUrl::fileName() will be an empty string, resulting in "From Here (/)"
    
    Do not hide the buttons in case the url is non-local, as it is confusing:
    1. The state depends on the previous search. When the user hits "Find"
        when browsing e.g an SMB share, the search was probably in the home dir.
    2. The current search location was hidden
    3. The user may want to do a local search, give the option to do so.
    
    Reviewers: #dolphin, ngraham, elvisangelaccio
    
    Reviewed By: #dolphin, ngraham, elvisangelaccio
    
    Subscribers: loh.tar, meven, elvisangelaccio, kfm-devel
    
    Tags: #dolphin
    
    Differential Revision: https://phabricator.kde.org/D20357
    9ce757b3