Skip to content
  • Nate Graham's avatar
    When filter bar is focused, switch to view when tab key is pressed · c22df71d
    Nate Graham authored
    Summary:
    Various people have requested that the tab key move keyboard focus from the filter bar's
    text edit field to the main view. It already does this when the Enter and return keys
    are pressed, but apparently this is not very intuitive and people expect Tab to work too.
    
    This patch makes that behavior possible by moving the Lock button to the left of the
    text edit field, and re-arranging the code so that the filter bar is initialized first.
    This works because Qt assigns tab ordering by default according to the order of widget
    construction. So if we simply construct the main view right after the filter bar, then
    the tab ordering is set up this way automatically.
    
    BUG: 403379
    BUG: 403356
    FIXED-IN: 19.08.0
    
    Test Plan:
    1. Activate Filter bar
    2. Hit Tab key
    3. View has become focused
    4. Play around in Dolphin for a while and notice no regressions or crashes
    
    Reviewers: #dolphin, elvisangelaccio
    
    Reviewed By: #dolphin, elvisangelaccio
    
    Subscribers: kfm-devel
    
    Tags: #dolphin
    
    Differential Revision: https://phabricator.kde.org/D21177
    c22df71d