Skip to content
  • Felix Ernst's avatar
    Animate most of the bars · f588a7d4
    Felix Ernst authored
    When a bar is toggled visible this usually happens because the
    user might want to use its functionality now. However, if bars
    appear without animation or at a location the user is not
    currently looking at, they might not notice that they have appeared
    at all.
    
    An animation makes it more likely that the user notices the change
    and can then use the newly made visible component.
    
    Another reason for animations for showing or hiding of components
    is that it can be disorienting for users when panels or bars
    suddenly appear or disappear without animation. There is no visible
    movement then, so the user might not know what happened if they
    didn't concentrate or blink at that moment. The newly appearing or
    disappearing component might also displace other components which
    can make it difficult to find what one was just looking at.
    
    These bars animate now after this change:
    - Search panel
    - Filter bar
    - Status bar
    
    This is implemented by extracting the animation code from
    SelectionMode::TopBar into a new abstract base class
    AnimatedHeightWidget. This class is now also used in
    SelectionMode::BottomBar and the animating code there was removed.
    
    These bars are left in Dolphin that stay without animation:
    - Menu bar (Would probably need to be implemented in KXmlGui)
    - Tool bar (Would probably need to be implemented in KXmlGui)
    - Tab bar (Needs a different appraoch because it already inherits
    QTabBar and therefore can not inherit AnimatedHeightWidget)
    f588a7d4