Skip to content

Avoid KJob::exec() in DolphinView

Felix Ernst requested to merge felixernst/dolphin:avoidjobexec into master

The documentation of KIO::KJob::exec() explains why it should be avoided. A reproducible crash (!86 (comment 162829)) is the reason for this MR.

KIO::StatJob::exec() in DolphinView is replaced with the recommended KIO::StatJob::start().

The calling method DolphinView::statusBarText() is changed to be a method without return value: requestStatusBarText(). The new status bar text is instead returned through a new signal that will be emitted asynchronously if necessary.

Code outside of DolphinView that deals with status bar text is refactored to correctly work despite the new asynchronicity.

Merge request reports