Skip to content

fix folder size calculation on FUSE and network file systems

Ilia Kats requested to merge (removed):fix_fuse_foldersize into master

As reported on BugZilla (430778, 431106, current Dolphin no longer calculates the size of a directory if the directory is not on a standard Linux filesystem. I encountered this on an NFS mount (which used to work in 20.08), while the two bugs linked above describe NTFS drives. The reason for the NTFS problem is as follows:

KFileItem::isSlow uses hardcoded logic that returns true if the filesystem is Smb or Nfs. However, KFileSystemType::determineFileSystemTypeImpl on Linux returns Nfs also if the file system in question is a FUSE file system, which includes NTFS, sshfs, and others.

I do not have an NTFS drive on hand to test, but Dolphin now again shows directory sizes on my NFS mount. While I understand the original reasoning behind excluding networked filesystems from potentially slow calculations, I think that most systems in the wild that are actually mounted should be fast enough, while network files accessed via KIO should be excluded by the isLocalFile check.

Merge request reports